Use actions/checkout for RPM/DEB build configuration in deployment workflow - #1096
Conversation
swissspidy
added
scope:testing
|
Warning Review limit reached
Next review available in: 34 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThe RPM and DEB packaging jobs now check out the ChangesPackaging workflow updates
Estimated code review effort: 2 (Simple) | ~10 minutes Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches 💡 1🛠️ Fix failing CI checks 💡
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Pull request overview
This PR updates the deployment workflow to source the RPM/DEB packaging configuration from a checked-out copy of the bundle repository, instead of downloading those files from raw.githubusercontent.com.
Changes:
- Add an additional
actions/checkoutstep to place the bundle repository underbundle/during RPM and DEB build jobs. - Replace
wgetdownloads of RPM/DEB build configuration files with localcpfrom the checked-outbundle/utils/paths.
Suppressed comments (1)
.github/workflows/deployment.yml:365
- Same as the RPM job: this checkout relies on implicit defaults for which repo/ref to fetch, even though the workspace root is a different checked-out repository (wp-cli/builds). Explicitly setting
repository/refhere makes it clear thatbundle/utils/wp-cli-updatedeb.shis coming from the workflow’s source repo at the triggering commit.
- name: Check out bundle repository
uses: actions/checkout@3d3c42e5aac5ba805825da76410c181273ba90b1 # v7.0.1
with:
path: bundle
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In @.github/workflows/deployment.yml:
- Around line 275-278: Set persist-credentials to false on the github.repository
checkout steps at .github/workflows/deployment.yml lines 275-278 and 361-364,
which are used only for copying bundle files. Leave the ACTIONS_BOT credentials
enabled on the wp-cli/builds checkout because later steps push gh-pages.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro Plus
Run ID: 8cc9b5ad-8563-46e9-ba4b-3f7444aa69b9
📒 Files selected for processing (1)
.github/workflows/deployment.yml
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
Summary by CodeRabbit